Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static serving to next server #33475

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Move static serving to next server #33475

merged 3 commits into from
Jan 19, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 19, 2022

Part of #31506

Decouple static serving logic from base-server, let them go to next-server only

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 19, 2022
@huozhi huozhi marked this pull request as ready for review January 19, 2022 21:15
@ijjk
Copy link
Member

ijjk commented Jan 19, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js base-server/static Change
buildDuration 13.8s 13.9s ⚠️ +49ms
buildDurationCached 3.1s 3.1s -51ms
nodeModulesSize 355 MB 355 MB ⚠️ +1.57 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js base-server/static Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.798 2.811 ⚠️ +0.01
/ avg req/sec 893.57 889.52 ⚠️ -4.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.198 1.192 -0.01
/error-in-render avg req/sec 2087.48 2098.12 +10.64
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js base-server/static Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js base-server/static Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js base-server/static Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.7 kB 4.7 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js base-server/static Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js base-server/static Change
index.html gzip 530 B 530 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js base-server/static Change
buildDuration 17.4s 17.4s ✓
buildDurationCached 3.1s 3.1s -30ms
nodeModulesSize 355 MB 355 MB ⚠️ +1.57 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js base-server/static Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.769 2.828 ⚠️ +0.06
/ avg req/sec 902.85 884.07 ⚠️ -18.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.162 1.184 ⚠️ +0.02
/error-in-render avg req/sec 2151.72 2111.6 ⚠️ -40.12
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js base-server/static Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js base-server/static Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js base-server/static Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js base-server/static Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js base-server/static Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 6f784b7

@kodiakhq kodiakhq bot merged commit 8ca32f1 into vercel:canary Jan 19, 2022
@shuding shuding mentioned this pull request Jan 19, 2022
Closed
15 tasks
@huozhi huozhi deleted the base-server/static branch January 20, 2022 14:15
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@huozhi @natew
Move static serving to next server (vercel#33475)
909961a 
Part of vercel#31506

Decouple static serving logic from base-server, let them go to next-server only
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @shuding